Skip to content

Commit

Permalink
build_request: always log when removing a plugin due to lack of config
Browse files Browse the repository at this point in the history
  • Loading branch information
twaugh committed Nov 11, 2015
1 parent 058fa31 commit a9cf5fc
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions osbs/build/build_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,8 @@ def render_sendmail(self):
raise OsbsValidationException('sendmail plugin configured, '
'but no pdc_secret_path')
else:
logger.info("removing sendmail from request, "
"requires pdc_url and smtp_uri")
self.dj.remove_plugin('exit_plugins', 'sendmail')

def render_cp_built_image_to_nfs(self):
Expand All @@ -602,6 +604,8 @@ def render_cp_built_image_to_nfs(self):
'dest_dir', self.spec.nfs_dest_dir.value)
else:
# Otherwise, don't run the NFS plugin
logger.info("removing cp_built_image_to_nfs from request, "
"requires nfs_server_path")
self.dj.remove_plugin("postbuild_plugins", "cp_built_image_to_nfs")

def render_pulp_push(self):
Expand All @@ -625,6 +629,8 @@ def render_pulp_push(self):
"but no auth config")
else:
# If no pulp registry is specified, don't run the pulp plugin
logger.info("removing pulp_push from request, "
"requires pulp_registry")
self.dj.remove_plugin("postbuild_plugins", "pulp_push")

def render_pulp_sync(self):
Expand Down Expand Up @@ -662,6 +668,8 @@ def render_pulp_sync(self):
"but no auth config")
else:
# If no pulp registry is specified, don't run the pulp plugin
logger.info("removing pulp_sync from request, "
"requires pulp_registry and a v2 registry")
self.dj.remove_plugin("postbuild_plugins", "pulp_sync")

def render_import_image(self, use_auth=None):
Expand Down

0 comments on commit a9cf5fc

Please sign in to comment.