Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/compose: Expose phases as [install, postprocess, commit] cmds #1062

Closed
cgwalters opened this issue Oct 16, 2017 · 1 comment
Closed

bin/compose: Expose phases as [install, postprocess, commit] cmds #1062

cgwalters opened this issue Oct 16, 2017 · 1 comment
Labels
jira for syncing to jira kind/enhancement

Comments

@cgwalters
Copy link
Member

cgwalters commented Oct 16, 2017

Right now rpm-ostree compose tree is very prescriptive about how things work.
Trying to add anything that isn't an RPM is absolutely fighting the system. Our
postprocessing system enforces no network access (good for reproducibilty, but
still prescriptive).

There's really a logical split between three phases:

  • install: "build a rootfs that installs packages"
  • postprocess: "run magical ostree postprocessing like kernel"
  • commit: "commit result to ostree"

So there are two high level flows I'd like to enable here. First is to allow
people to do arbitrary postprocessing between install and commit. For
example, run Ansible and change /etc. This path basically is like what we have
today with postprocess-script.sh, except the builder can do anything they want
with network access enabled.

Going much farther, this helps us support a "build with Dockerfile" style flow.
We can then provide tooling to extract the container image, and combine
postprocess and commit.

Or completely the other way - if for example someone wants to use rpm-ostree compose install, they could tar up the result as a Docker/OCI image. That's now
easier; an advantage of this flow over e.g. yum --installroot is the "change
detection" code we have.

Related issues/PRs:

One disadvantage of this approach right now is that if one does go for
the split approach, we lose the "input hash" metadata for example. And
down the line, I'd like to add even more metadata, like the input rpm repos,
which could also be rendered on the client side.

But, I think we can address that later by e.g. caching the metadata in a file in
the install root and picking it back up or something.

@cgwalters cgwalters added the jira for syncing to jira label Oct 16, 2017
@cgwalters cgwalters changed the title Split commit -> install-root and commit-root bin/compose: Expose phases as [install, postprocess, commit] cmds Oct 17, 2017
@cgwalters
Copy link
Member Author

This was fixed by #1039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira for syncing to jira kind/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants