Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etc group members #50

Closed
wants to merge 2 commits into from
Closed

Conversation

cgwalters
Copy link
Member

No description provided.

Originally I was trying to have all of the treefile parsing
in treecompose, and then call other functions as API.  But that
turns out to be unrealistic.  We'll need finer grained control
over this in the future.

Therefore, let's move the boot-location handling down, in preparation
for further commits which parse the treefile in the commit phase.
Currently adding human users to a system group such as 'wheel' does
not work with shadow-utils as it exists now.  This is admittedly
a hack; basically we single out "wheel" as going in /etc/group, via:

    "etc-group-members": ["wheel"],

A more comprehensive solution to this will be:
coreos#49
@mbarnes
Copy link
Contributor

mbarnes commented Nov 17, 2014

Looks good to me. The only nit I saw (and it's a tiny one) was when using a GHashTable as a set like in _rpmostree_jsonutil_jsarray_strings_to_set(), it reads a little clearer to use g_hash_table_add() instead of g_hash_table_insert() or replace() with identical key and value.

@cgwalters
Copy link
Member Author

Ah right, thanks, fixed.

On Mon, Nov 17, 2014, at 12:30 PM, Matthew Barnes wrote:

Looks good to me. The only nit I saw (and it's a tiny one) was when
using a GHashTable as a set like in
_rpmostree_jsonutil_jsarray_strings_to_set(), it reads a little
clearer to use g_hash_table_add() instead of g_hash_table_insert() or
replace() with identical key and value.

— Reply to this email directly or view it on GitHub[1].

Links:

  1. Etc group members #50 (comment)

@cgwalters
Copy link
Member Author

Merged.

@cgwalters cgwalters closed this Nov 17, 2014
@cgwalters cgwalters deleted the etc-group-members branch November 17, 2014 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants