Skip to content
This repository has been archived by the owner on Jul 29, 2018. It is now read-only.

vagrant-service-manager 1.0.2 release #181

Closed
16 tasks done
navidshaikh opened this issue Apr 14, 2016 · 4 comments
Closed
16 tasks done

vagrant-service-manager 1.0.2 release #181

navidshaikh opened this issue Apr 14, 2016 · 4 comments

Comments

navidshaikh added a commit to navidshaikh/vagrant-service-manager that referenced this issue Apr 14, 2016
navidshaikh added a commit to navidshaikh/vagrant-service-manager that referenced this issue Apr 14, 2016
@navidshaikh
Copy link
Collaborator Author

navidshaikh commented Apr 18, 2016

I'll vote for including the whatever actions needed to fix issue #184 in upcoming release of plugin. And I think that needs to bump the Y stream of the plugin, and the release would be 1.1.0.

@bexelbie : comments ?

@bexelbie
Copy link
Contributor

@navidshaikh I believe the fixes are already in. I'm ambivalent about bumping the Y stream.

@navidshaikh
Copy link
Collaborator Author

navidshaikh commented Apr 20, 2016

Here is the copy of proposal

Command Extra flag Output Type
env eval'able info from docker and openshift
env --script-readable k=v format for docker and openshift, with user-readable strings commented
env docker eval-able (Cannot be changed, except make more easily eval'd on windows? dangerous though)
env docker --script-readable K=V properties format with user-readable strings commented
env openshift eval'able
env openshift --script-readable K=V syntax with user-readable strings commented (ie, today's –script-readable format)

And here are the commands and their output. @robstryker @hferentschik @maxandersen please review.

➜ vagrant service-manager env
# docker env:
# Set the following environment variables to enable access to the
# docker daemon running inside of the vagrant virtual machine:
export DOCKER_HOST=tcp://172.28.128.8:2376
export DOCKER_CERT_PATH=/home/nshaikh/work/src/vagrant-service-manager/.vagrant/machines/default/virtualbox/docker
export DOCKER_TLS_VERIFY=1
export DOCKER_API_VERSION=1.21
# run following command to configure your shell:
# eval "$(vagrant service-manager env docker)"

# openshift env:
# You can access the OpenShift console on: https://172.28.128.8:8443/console
# To use OpenShift CLI, run: oc login https://172.28.128.8:8443
➜ vagrant service-manager env --script-readable
DOCKER_HOST=tcp://172.28.128.8:2376
DOCKER_CERT_PATH='/home/nshaikh/work/src/vagrant-service-manager/.vagrant/machines/default/virtualbox/docker'
DOCKER_TLS_VERIFY=1
DOCKER_API_VERSION=1.21
OPENSHIFT_URL=https://172.28.128.8:8443
OPENSHIFT_WEB_CONSOLE=https://172.28.128.8:8443/console
➜ vagrant service-manager env docker           
# Set the following environment variables to enable access to the
# docker daemon running inside of the vagrant virtual machine:
export DOCKER_HOST=tcp://172.28.128.8:2376
export DOCKER_CERT_PATH=/home/nshaikh/work/src/vagrant-service-manager/.vagrant/machines/default/virtualbox/docker
export DOCKER_TLS_VERIFY=1
export DOCKER_API_VERSION=1.21
# run following command to configure your shell:
# eval "$(vagrant service-manager env docker)"
➜ vagrant service-manager env docker --script-readable
DOCKER_HOST=tcp://172.28.128.8:2376
DOCKER_CERT_PATH='/home/nshaikh/work/src/vagrant-service-manager/.vagrant/machines/default/virtualbox/docker'
DOCKER_TLS_VERIFY=1
DOCKER_API_VERSION=1.21
➜ vagrant service-manager env openshift               
# You can access the OpenShift console on: https://172.28.128.8:8443/console
# To use OpenShift CLI, run: oc login https://172.28.128.8:8443
➜ vagrant service-manager env openshift --script-readable
OPENSHIFT_URL=https://172.28.128.8:8443
OPENSHIFT_WEB_CONSOLE=https://172.28.128.8:8443/console

@maxandersen
Copy link

looks good, one comment is that this part from env docker:

# run following command to configure your shell:
# eval "$(vagrant service-manager env docker)"

should not be unique to the docker command.

I would have any output of env just output it at the end (once).
i.e. if I just call env I get this at the end:

# run following command to configure your shell:
# eval "$(vagrant service-manager env)"

if I call env openshift I get:

# run following command to configure your shell:
# eval "$(vagrant service-manager env openshift)"

navidshaikh added a commit to navidshaikh/vagrant-service-manager that referenced this issue May 9, 2016
navidshaikh added a commit to navidshaikh/vagrant-service-manager that referenced this issue May 9, 2016
navidshaikh added a commit to navidshaikh/vagrant-service-manager that referenced this issue May 9, 2016
navidshaikh added a commit that referenced this issue May 9, 2016
Fix #181: vagrant-service-manager version 1.0.2 release
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants