Skip to content
This repository has been archived by the owner on Jul 29, 2018. It is now read-only.

Implement style guide based test using rubocop #93

Closed
coolbrg opened this issue Mar 4, 2016 · 5 comments
Closed

Implement style guide based test using rubocop #93

coolbrg opened this issue Mar 4, 2016 · 5 comments
Assignees
Milestone

Comments

@coolbrg
Copy link
Contributor

coolbrg commented Mar 4, 2016

Rubocopis a great gem in Ruby for static code ananlyzer.
Adding it as part of tests would insure that code follow language code standards.

@navidshaikh Please add label test to this issue.

@navidshaikh navidshaikh added this to the v1.1 milestone May 16, 2016
@hferentschik hferentschik modified the milestones: v1.2.0, v2.0.0 Jun 22, 2016
@hferentschik
Copy link
Contributor

@budhrg Are you up for adding Rubocop. I would like to basically add it and be able to run its target (bundle exec rake rubocop). We can go for now with the default checks, but we don't need to fix all violations at once (maybe the most apparent ones). Instead we add a rubocop_todo to exclude the violations. The aim would be to reduce the items in the todo as we go, potentially also adjusting the rules, if we don't agree with them. FYI, rubocop_todo can be auto-generated.

Should not take long to do this and I think it would be a good start to converge on some common Ruby style.

@coolbrg coolbrg removed their assignment Jun 22, 2016
@coolbrg
Copy link
Contributor Author

coolbrg commented Jun 22, 2016

@hferentschik Good idea 👍 Lets do that.

@hferentschik
Copy link
Contributor

Thanks

@coolbrg
Copy link
Contributor Author

coolbrg commented Jul 7, 2016

@hferentschik are you working on it?

@hferentschik
Copy link
Contributor

No .

@hferentschik hferentschik self-assigned this Jul 8, 2016
hferentschik added a commit to hferentschik/vagrant-service-manager that referenced this issue Jul 9, 2016
hferentschik added a commit to hferentschik/vagrant-service-manager that referenced this issue Jul 9, 2016
hferentschik added a commit to hferentschik/vagrant-service-manager that referenced this issue Jul 9, 2016
- Autocorrect with Rubocop and fixing simple violations
- Adjusting line length setting and adding rubocop_todo.yml
hferentschik added a commit to hferentschik/vagrant-service-manager that referenced this issue Jul 9, 2016
- Autocorrect with Rubocop and fixing simple violations
- Adjusting line length setting and adding rubocop_todo.yml
hferentschik added a commit to hferentschik/vagrant-service-manager that referenced this issue Jul 10, 2016
- Autocorrect with Rubocop and fixing simple violations
- Adjusting line length setting and adding rubocop_todo.yml
hferentschik added a commit to hferentschik/vagrant-service-manager that referenced this issue Jul 11, 2016
- Autocorrect with Rubocop and fixing simple violations
- Adjusting line length setting and adding rubocop_todo.yml
hferentschik added a commit to hferentschik/vagrant-service-manager that referenced this issue Jul 11, 2016
- Autocorrect with Rubocop and fixing simple violations
- Adjusting line length setting and adding rubocop_todo.yml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants