New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HydraConnect refactor #55
HydraConnect refactor #55
Conversation
@@ -23,6 +23,7 @@ Gem::Specification.new do |spec| | |||
spec.add_dependency "leaflet-rails" | |||
spec.add_dependency "leaflet-markercluster-rails" | |||
spec.add_dependency "leaflet-sidebar-rails", "~> 0.0.2" | |||
#spec.add_dependency "c_geohash", "~> 1.1.2" # don't need if location_rpt can't be faceted properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like cruft here. Is it necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, leftover from some experimentation I was doing. Will remove.
I pushed up a commit to address the gemspec/Rspec issues you commented on. |
@ebenenglish great thanks. Also it looks like it will also need a rebase (merge conflicts). Can you please do a rebase off of master and then push back up? |
…r helpers for easier local customization
…enderConstraintsOverride
5478bf9
to
a69322c
Compare
Rebase done; looks like build failing due to a few tests failing with Ruby 1.9.3. Are we still supporting this version of Ruby? If so I'll see if I can get these working... |
All tests should now be passing in Ruby 1.9.3. Latest build failed under 2.2.0 and 2.0.0 (but passed for 2.1.0 and 1.9.3) because of a weird Poltergeist timeout error:
Not sure if this is a random momentary glitch or what, but this didn't come up in previous builds, and all tests are passing on my end. |
Ok removing jruby and 1.9.3 from travis with #57 ... rerunning travis to see if I can get it to pass. |
@ebenenglish Do you have this deployed somewhere I can play with? Thanks! |
Yes, it's been deployed on the Digital Commonwealth production site: The deployment is basically "out of the box" except for the |
So here's the refactor based on our discussions at Hydra Connect and on the Blacklight-development list. To summarize, the main changes are:
Note: there are a handful of tests that are 'pending' because I couldn't get them passing despite extensive effort. But, they seemed important so I left them in -- hopefully someone can get these working?
Other note: I haven't updated the version. Let me know if that's something I should be doing before submitting the PR.
Thanks for everyone's patience on this!