Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update blacklight-maps for blacklight 6 compatibility #82

Merged

Conversation

ebenenglish
Copy link
Contributor

This PR updates the engine to work with Blacklight >= 6.1.0.

If the build passes, I will rebase and squash everything into one commit.

Once this PR is merged, we will update the version to 0.5.0.

@ebenenglish
Copy link
Contributor Author

ebenenglish commented Jun 7, 2016

Coverage decrease seems largely related to lack of coverage for lib/generators/blacklight_maps/install_generator.rb, to which a few new methods were added, and a few new classes in lib/generators/blacklight_maps/templates/.

Other than that this PR doesn't introduce any new classes or methods, and doesn't add/remove any specs.

@ebenenglish
Copy link
Contributor Author

@mejackreed Any thoughts?

@mejackreed
Copy link
Contributor

Seems ok. Though I haven't been looking at this codebase in a while. Happy to press the green button :)

@mejackreed mejackreed merged commit 411282e into projectblacklight:master Jun 16, 2016
@ebenenglish ebenenglish deleted the update-to-blacklight-6 branch June 16, 2016 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants