Fix a regression from 8b658e6 to allow show views to use different i1…

…8n'ed labels
projectblacklight · Sep 30, 2020 · 312a4ea · 312a4ea
1 parent 6c15f20
commit 312a4ea
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/app/components/blacklight/metadata_field_component.rb b/app/components/blacklight/metadata_field_component.rb
@@ -17,7 +17,7 @@ def initialize(field:, layout: nil, show: false)
     def label
       Deprecation.silence(Blacklight::BlacklightHelperBehavior) do
         if @show
-          @view_context.render_document_show_field_label @field.document, label: @field.label, field: @field.key
+          @view_context.render_document_show_field_label @field.document, label: @field.label('show'), field: @field.key
         else
           @view_context.render_index_field_label @field.document, label: @field.label, field: @field.key
         end

diff --git a/spec/components/blacklight/metadata_field_component_spec.rb b/spec/components/blacklight/metadata_field_component_spec.rb
@@ -26,4 +26,16 @@
   it 'renders the field value' do
     expect(rendered).to have_selector 'dd.blacklight-field', text: 'Value'
   end
+
+  context 'from a show view' do
+    subject(:render) do
+      render_inline(described_class.new(field: field, show: true))
+    end
+
+    it 'renders the right field label' do
+      allow(field).to receive(:label).with('show').and_return('custom label')
+
+      expect(rendered).to have_selector 'dt.blacklight-field', text: 'custom label'
+    end
+  end
 end