Merge pull request #2709 from projectblacklight/deprecate_helper

Remove render_document_main_content_partial helper
projectblacklight · May 7, 2022 · 4d061f0 · 4d061f0
2 parents ed767db + ffc52e2
commit 4d061f0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/app/helpers/blacklight/catalog_helper_behavior.rb b/app/helpers/blacklight/catalog_helper_behavior.rb
@@ -147,17 +147,6 @@ def render_document_sidebar_partial(document)
     render 'show_sidebar', document: document
   end
 
-  ##
-  # Render the main content partial for a document
-  # This is widely used as by downstream apps when they override their show view.
-  # See https://github.com/search?q=render_document_main_content_partial&type=Code
-  #
-  # @param [SolrDocument] _document
-  # @return [String]
-  def render_document_main_content_partial(_document = @document)
-    render partial: 'show_main_content'
-  end
-
   ##
   # Should we display the sort and per page widget?
   #

diff --git a/app/views/catalog/show.html.erb b/app/views/catalog/show.html.erb
@@ -5,7 +5,7 @@
   </div>
 <% end %>
 
-<%= render_document_main_content_partial %>
+<%= render 'show_main_content' %>
 
 <% content_for(:sidebar) do %>
   <%= render_document_sidebar_partial @document %>