Skip to content

Commit

Permalink
Merge c4950b7 into 2461525
Browse files Browse the repository at this point in the history
  • Loading branch information
mejackreed committed Oct 7, 2016
2 parents 2461525 + c4950b7 commit d4a8d90
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 14 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ rvm:

matrix:
include:
- rvm: 2.2.5
env: "RAILS_VERSION=4.0.13"
- rvm: 2.2.5
env: "RAILS_VERSION=4.1.13"
- rvm: 2.1.5
Expand Down
28 changes: 18 additions & 10 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ group :test do
end

# BEGIN ENGINE_CART BLOCK
# engine_cart: 0.8.0
# engine_cart stanza: 0.8.0
# engine_cart: 0.10.0
# engine_cart stanza: 0.10.0
# the below comes from engine_cart, a gem used to test this Rails engine gem in the context of a Rails app.
file = File.expand_path("Gemfile", ENV['ENGINE_CART_DESTINATION'] || ENV['RAILS_ROOT'] || File.expand_path(".internal_test_app", File.dirname(__FILE__)))
file = File.expand_path('Gemfile', ENV['ENGINE_CART_DESTINATION'] || ENV['RAILS_ROOT'] || File.expand_path('.internal_test_app', File.dirname(__FILE__)))
if File.exist?(file)
begin
eval_gemfile file
Expand All @@ -27,14 +27,22 @@ if File.exist?(file)
else
Bundler.ui.warn "[EngineCart] Unable to find test application dependencies in #{file}, using placeholder dependencies"

gem 'rails', ENV['RAILS_VERSION'] if ENV['RAILS_VERSION']
if ENV['RAILS_VERSION']
if ENV['RAILS_VERSION'] == 'edge'
gem 'rails', github: 'rails/rails'
ENV['ENGINE_CART_RAILS_OPTIONS'] = '--edge --skip-turbolinks'
else
gem 'rails', ENV['RAILS_VERSION']
end
end

if ENV['RAILS_VERSION'].nil? || ENV['RAILS_VERSION'] =~ /^4.2/
gem 'responders', "~> 2.0"
gem 'sass-rails', ">= 5.0"
else
gem 'bootstrap-sass', '< 3.3.5' # 3.3.5 requires sass 3.3, incompatible with sass-rails 4.x
gem 'sass-rails', "< 5.0"
case ENV['RAILS_VERSION']
when /^4.2/
gem 'responders', '~> 2.0'
gem 'sass-rails', '>= 5.0'
gem 'coffee-rails', '~> 4.1.0'
when /^4.[01]/
gem 'sass-rails', '< 5.0'
end
end
# END ENGINE_CART BLOCK
2 changes: 1 addition & 1 deletion app/assets/javascripts/blacklight/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Blacklight = function() {

listeners: function () {
var listeners = [];
if (Turbolinks && Turbolinks.supported) {
if (typeof Turbolinks !== 'undefined' && Turbolinks.supported) {
// Turbolinks 5
if (Turbolinks.BrowserAdapter) {
listeners.push('turbolinks:load');
Expand Down
2 changes: 1 addition & 1 deletion blacklight.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ Gem::Specification.new do |s|
s.add_development_dependency "rspec-collection_matchers", ">= 1.0"
s.add_development_dependency "capybara"
s.add_development_dependency "poltergeist"
s.add_development_dependency 'engine_cart', '~> 0.8.0'
s.add_development_dependency 'engine_cart', '~> 1.0'
s.add_development_dependency "equivalent-xml"
end

0 comments on commit d4a8d90

Please sign in to comment.