ends_with? => end_with?

projectblacklight · Apr 26, 2021 · ea9b61f · ea9b61f
1 parent ba2649a
commit ea9b61f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/blacklight/nested_open_struct_with_hash_access.rb b/lib/blacklight/nested_open_struct_with_hash_access.rb
@@ -92,11 +92,11 @@ def merge! other_hash
     def method_missing(mid, *args, **kwargs, &block)
       len = args.length
 
-      res = if mid.to_s.ends_with?('!')
+      res = if mid.to_s.end_with?('!')
               m = mid[0...-1]
               new_ostruct_member!(m)
               @table[m]
-            elsif mid.to_s.ends_with?('=')
+            elsif mid.to_s.end_with?('=')
               m = mid[0...-1]
               new_ostruct_member!(m)
               @table[m] = args.first

diff --git a/spec/lib/blacklight/nested_open_struct_with_hash_access_spec.rb b/spec/lib/blacklight/nested_open_struct_with_hash_access_spec.rb
@@ -23,4 +23,18 @@
       expect(subject.blah).to have_attributes(key: :blah)
     end
   end
+
+  describe 'adding new parameters' do
+    subject { described_class.new(Blacklight::Configuration::Field) }
+
+    it 'strips the trailing !' do
+      subject.blaH!
+      expect(subject.blah).to have_attributes(key: :blah)
+    end
+
+    it 'supports direct assignment' do
+      subject.blah = '123'
+      expect(subject.blah).to eq '123'
+    end
+  end
 end