Remove deprecated behaviors

projectblacklight · Sep 7, 2016 · f1a8cf4 · f1a8cf4
1 parent d34300d
commit f1a8cf4
Show file tree

Hide file tree

Showing 23 changed files with 37 additions and 1,144 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,20 +1,19 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-08-25 07:56:15 -0700 using RuboCop version 0.42.0.
+# on 2016-09-07 07:22:49 -0700 using RuboCop version 0.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 19
+# Offense count: 17
 # Cop supports --auto-correct.
 # Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
 # SupportedStyles: keyword, variable, start_of_line
 Lint/EndAlignment:
   Exclude:
     - 'app/controllers/concerns/blacklight/token_based_user.rb'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
-    - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
     - 'app/helpers/blacklight/facets_helper_behavior.rb'
     - 'app/helpers/blacklight/render_partials_helper.rb'
     - 'app/helpers/blacklight/url_helper_behavior.rb'
@@ -25,15 +24,14 @@ Lint/EndAlignment:
     - 'lib/blacklight/solr/response/facets.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 30
+# Offense count: 26
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Exclude:
     - 'app/controllers/concerns/blacklight/search_context.rb'
     - 'app/helpers/blacklight/configuration_helper_behavior.rb'
     - 'app/models/concerns/blacklight/document/dublin_core.rb'
-    - 'lib/blacklight/configuration.rb'
     - 'lib/blacklight/configuration/fields.rb'
     - 'lib/blacklight/engine.rb'
     - 'lib/blacklight/parameters.rb'
@@ -42,17 +40,15 @@ Lint/UnusedBlockArgument:
     - 'lib/railties/blacklight.rake'
     - 'tasks/blacklight.rake'
 
-# Offense count: 21
+# Offense count: 18
 # Cop supports --auto-correct.
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
 Lint/UnusedMethodArgument:
   Exclude:
-    - 'app/controllers/concerns/blacklight/default_component_configuration.rb'
     - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'app/helpers/blacklight/component_helper_behavior.rb'
     - 'app/helpers/blacklight/configuration_helper_behavior.rb'
-    - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
     - 'app/helpers/blacklight/facets_helper_behavior.rb'
     - 'app/helpers/blacklight/render_partials_helper.rb'
     - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
@@ -62,11 +58,10 @@ Lint/UnusedMethodArgument:
     - 'lib/blacklight/search_builder.rb'
     - 'lib/blacklight/search_state.rb'
 
-# Offense count: 9
+# Offense count: 7
 Lint/UselessAssignment:
   Exclude:
     - 'app/controllers/concerns/blacklight/search_context.rb'
-    - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
     - 'app/helpers/blacklight/facets_helper_behavior.rb'
     - 'app/models/bookmark.rb'
     - 'lib/blacklight/routes/exportable.rb'
@@ -85,21 +80,21 @@ Metrics/BlockNesting:
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 200
+  Max: 185
 
 # Offense count: 20
 Metrics/CyclomaticComplexity:
   Max: 12
 
-# Offense count: 59
+# Offense count: 54
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 52
+  Max: 51
 
 # Offense count: 9
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 213
+  Max: 208
 
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs.
@@ -132,7 +127,7 @@ Style/Alias:
     - 'lib/blacklight/solr/response.rb'
     - 'lib/blacklight/solr/response/group_response.rb'
 
-# Offense count: 7
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
 # SupportedStyles: with_first_parameter, with_fixed_indentation
@@ -143,7 +138,7 @@ Style/AlignParameters:
     - 'lib/blacklight/configuration.rb'
     - 'lib/generators/blacklight/solr4_generator.rb'
 
-# Offense count: 66
+# Offense count: 64
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: always, conditionals
@@ -160,17 +155,15 @@ Style/BracesAroundHashParameters:
     - 'lib/blacklight/solr/response/facets.rb'
     - 'lib/generators/blacklight/test_support_generator.rb'
 
-# Offense count: 13
+# Offense count: 8
 # Cop supports --auto-correct.
 # Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
 Style/CaseIndentation:
   Exclude:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
-    - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
     - 'app/presenters/blacklight/index_presenter.rb'
     - 'lib/blacklight/configuration/fields.rb'
-    - 'lib/blacklight/search_builder.rb'
 
 # Offense count: 51
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -186,7 +179,7 @@ Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 104
+# Offense count: 103
 Style/Documentation:
   Enabled: false
 
@@ -216,15 +209,14 @@ Style/ElseAlignment:
     - 'lib/blacklight/solr/response/facets.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 26
+# Offense count: 25
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
 Style/ExtraSpacing:
   Exclude:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'app/helpers/blacklight/configuration_helper_behavior.rb'
     - 'app/models/concerns/blacklight/document/dublin_core.rb'
-    - 'app/models/concerns/blacklight/document/export.rb'
     - 'app/models/record_mailer.rb'
     - 'blacklight.gemspec'
     - 'config/routes.rb'
@@ -254,7 +246,7 @@ Style/GuardClause:
 Style/HashSyntax:
   Enabled: false
 
-# Offense count: 16
+# Offense count: 15
 # Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.
 Style/IfUnlessModifier:
@@ -265,7 +257,6 @@ Style/IfUnlessModifier:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'app/helpers/blacklight/url_helper_behavior.rb'
     - 'app/models/blacklight/facet_paginator.rb'
-    - 'lib/blacklight/configuration.rb'
     - 'lib/blacklight/configuration/fields.rb'
     - 'lib/blacklight/search_state.rb'
     - 'lib/generators/blacklight/install_generator.rb'
@@ -279,7 +270,7 @@ Style/IndentHash:
   Exclude:
     - 'lib/blacklight/configuration.rb'
 
-# Offense count: 23
+# Offense count: 22
 # Cop supports --auto-correct.
 # Configuration parameters: Width.
 Style/IndentationWidth:
@@ -308,7 +299,7 @@ Style/LeadingCommentSpace:
     - 'lib/blacklight/configuration.rb'
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 139
+# Offense count: 119
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
@@ -331,7 +322,7 @@ Style/MultilineMethodCallIndentation:
     - 'app/controllers/concerns/blacklight/search_helper.rb'
     - 'lib/blacklight/search_builder.rb'
 
-# Offense count: 13
+# Offense count: 12
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
 # SupportedStyles: aligned, indented
@@ -372,7 +363,7 @@ Style/PredicateName:
 Style/RedundantSelf:
   Enabled: false
 
-# Offense count: 24
+# Offense count: 17
 # Cop supports --auto-correct.
 Style/SpaceAfterComma:
   Exclude:
@@ -381,7 +372,6 @@ Style/SpaceAfterComma:
     - 'app/helpers/blacklight/facets_helper_behavior.rb'
     - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
     - 'app/models/concerns/blacklight/document/dublin_core.rb'
-    - 'lib/blacklight/configuration.rb'
     - 'lib/blacklight/configuration/fields.rb'
     - 'lib/blacklight/parameters.rb'
     - 'lib/blacklight/solr/response/facets.rb'
@@ -397,7 +387,7 @@ Style/SpaceAroundBlockParameters:
     - 'app/controllers/concerns/blacklight/catalog.rb'
     - 'app/models/concerns/blacklight/document/extensions.rb'
 
-# Offense count: 27
+# Offense count: 23
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: space, no_space
@@ -408,15 +398,13 @@ Style/SpaceAroundEqualsInParameterDefault:
     - 'app/helpers/blacklight/component_helper_behavior.rb'
     - 'app/helpers/blacklight/configuration_helper_behavior.rb'
     - 'app/helpers/blacklight/facets_helper_behavior.rb'
-    - 'app/helpers/blacklight/render_partials_helper.rb'
     - 'app/helpers/blacklight/url_helper_behavior.rb'
     - 'app/models/concerns/blacklight/document.rb'
-    - 'app/presenters/blacklight/document_presenter.rb'
     - 'app/presenters/blacklight/index_presenter.rb'
     - 'app/presenters/blacklight/show_presenter.rb'
     - 'lib/blacklight/search_state.rb'
 
-# Offense count: 13
+# Offense count: 12
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment.
 Style/SpaceAroundOperators:
@@ -426,7 +414,6 @@ Style/SpaceAroundOperators:
     - 'app/helpers/blacklight/facets_helper_behavior.rb'
     - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
     - 'app/helpers/blacklight/url_helper_behavior.rb'
-    - 'app/models/concerns/blacklight/document/export.rb'
     - 'lib/blacklight/configuration.rb'
     - 'lib/blacklight/solr/repository.rb'
     - 'lib/blacklight/solr/response/spelling.rb'
@@ -497,14 +484,13 @@ Style/SpaceInsideHashLiteralBraces:
     - 'lib/blacklight/configuration.rb'
     - 'lib/blacklight/solr/repository.rb'
 
-# Offense count: 19
+# Offense count: 18
 # Cop supports --auto-correct.
 Style/SpaceInsideParens:
   Exclude:
     - 'app/controllers/concerns/blacklight/search_context.rb'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'app/helpers/blacklight/facets_helper_behavior.rb'
-    - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
     - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
     - 'app/helpers/blacklight/url_helper_behavior.rb'
     - 'app/models/concerns/blacklight/document/dublin_core.rb'
@@ -513,8 +499,7 @@ Style/SpaceInsideParens:
     - 'lib/blacklight/search_state.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 217
+# Offense count: 197
 # Cop supports --auto-correct.
 Style/TrailingWhitespace:
   Enabled: false
-
diff --git a/app/assets/stylesheets/blacklight/_facets.scss b/app/assets/stylesheets/blacklight/_facets.scss
@@ -106,13 +106,6 @@
 
 }
 
-/* deprecated in Blacklight 5.x */
-ul.facet_extended_list, .facet_extended_list ul
-{
-  @extend .list-unstyled;
-
-}
-
 .collapse-toggle {
   cursor: pointer;
 }