Handle user-supplied facet value parameters as arrays or strings

projectblacklight · Aug 31, 2016 · f8aed34 · f8aed34
1 parent d914c53
commit f8aed34
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/app/helpers/blacklight/render_constraints_helper_behavior.rb b/app/helpers/blacklight/render_constraints_helper_behavior.rb
@@ -84,12 +84,12 @@ def render_constraints_filters(localized_params = params)
   def render_filter_element(facet, values, path)
     facet_config = facet_configuration_for_field(facet)
 
-    safe_join(values.map do |val|
+    safe_join(Array(values).map do |val|
       next if val.blank? # skip empty string
-      render_constraint_element( facet_field_label(facet_config.key), facet_display_value(facet, val),
-                  remove: search_action_path(path.remove_facet_params(facet, val)),
-                  classes: ["filter", "filter-" + facet.parameterize]
-                )
+      render_constraint_element(facet_field_label(facet_config.key),
+                                facet_display_value(facet, val),
+                                remove: search_action_path(path.remove_facet_params(facet, val)),
+                                classes: ["filter", "filter-" + facet.parameterize])
     end, "\n")
   end
 

diff --git a/spec/helpers/render_constraints_helper_spec.rb b/spec/helpers/render_constraints_helper_spec.rb
@@ -56,6 +56,14 @@
       expect(subject).to have_link "Remove constraint Item Type: journal", href: "/catalog?q=biz"
       expect(subject).to have_selector ".filterName", text: 'Item Type'
     end
+
+    context 'with string values' do
+      subject { helper.render_filter_element('type', 'journal', path) }
+
+      it "handles string values gracefully" do
+        expect(subject).to have_link "Remove constraint Item Type: journal", href: "/catalog?q=biz"
+      end
+    end
   end
 
   describe "#render_constraints_filters" do