Update rubocop-rspec to ~>1.43

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-08-28 22:51:36 UTC using RuboCop version 0.89.1.
+# on 2020-08-28 23:25:40 UTC using RuboCop version 0.89.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,6 +12,14 @@ Capybara/CurrentPathExpectation:
   Exclude:
     - 'spec/features/alternate_controller_spec.rb'
 
+# Offense count: 20
+Capybara/VisibilityMatcher:
+  Exclude:
+    - 'spec/features/facets_spec.rb'
+    - 'spec/features/search_filters_spec.rb'
+    - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
+
 # Offense count: 8
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
@@ -274,20 +282,21 @@ RSpec/BeforeAfterAll:
     - 'spec/models/blacklight/document/sms_spec.rb'
     - 'spec/models/blacklight/solr/document_spec.rb'
 
-# Offense count: 80
+# Offense count: 81
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 55
+# Offense count: 42
 RSpec/DescribeClass:
   Enabled: false
 
-# Offense count: 1
+# Offense count: 2
 # Configuration parameters: CustomIncludeMethods.
 RSpec/EmptyExampleGroup:
   Exclude:
+    - 'spec/helpers/blacklight_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
 # Offense count: 134
@@ -305,7 +314,7 @@ RSpec/ExpectInHook:
     - 'spec/helpers/catalog_helper_spec.rb'
 
 # Offense count: 5
-# Configuration parameters: CustomTransform, IgnoreMethods.
+# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
 RSpec/FilePath:
   Exclude:
     - 'spec/controllers/blacklight/catalog/component_configuration_spec.rb'
@@ -365,10 +374,14 @@ RSpec/MessageSpies:
     - 'spec/presenters/thumbnail_presenter_spec.rb'
 
 # Offense count: 363
-# Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 16
 
+# Offense count: 160
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 14
+
 # Offense count: 337
 # Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
@@ -392,16 +405,25 @@ RSpec/RepeatedExample:
     - 'spec/models/blacklight/solr/document_spec.rb'
 
 # Offense count: 4
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
+    - 'spec/services/blacklight/search_service_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
 RSpec/ScatteredLet:
   Exclude:
     - 'spec/helpers/catalog_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 10
+# Offense count: 13
 RSpec/SubjectStub:
   Exclude:
+    - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/lib/blacklight/search_state_spec.rb'
+    - 'spec/models/blacklight/document/cache_key_spec.rb'
     - 'spec/models/blacklight/search_builder_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 

blacklight.gemspec

@@ -44,6 +44,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency "simplecov"
   s.add_development_dependency "rubocop", '~> 0.85'
   s.add_development_dependency "rubocop-rails", '~> 2.6'
-  s.add_development_dependency "rubocop-rspec", '~> 1.8'
+  s.add_development_dependency "rubocop-rspec", '~> 1.43'
   s.add_development_dependency "i18n-tasks"
 end