Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve view components deprecation of `require "view_component/engine" #2619

Closed
hackartisan opened this issue Feb 15, 2022 · 4 comments
Closed
Assignees

Comments

@hackartisan
Copy link
Contributor

hackartisan commented Feb 15, 2022

When blacklight pins view component to 2.46 or higher (in the course of regular maintenance or feature work requiring a later version of view component) it will be good to resolve this deprecation.

This deprecation was introduced in 2.46. https://viewcomponent.org/CHANGELOG.html#2460

The require is here

require 'view_component'

Currently Blacklight requires view component 2.43. https://github.com/projectblacklight/blacklight/blob/31a3990ccf9e389a0962876b09b6ff31f5e3fd77/blacklight.gemspec

@jcoyne
Copy link
Member

jcoyne commented Feb 15, 2022

@hackartisan wasn't this resolved with 7a1590c ?

@hackartisan
Copy link
Contributor Author

Yes! And that should fix it. It just hasn't been released I guess. Should it be backported to 7.x?

@jcoyne
Copy link
Member

jcoyne commented Feb 15, 2022

Yeah, I don't believe there is a release for this. Backporting seems like a good idea to me.

@hackartisan
Copy link
Contributor Author

I can do a backport PR. I can't apply the label or assign myself, though, because of permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants