Changing facet sort is broken in pagination view when default sort is set

[devn]

If you set:

config.default_solr_params = {
  ...
  :'f.foo.facet.sort' => 'index',
  ...
}

You will be unable to switch to Numeric sorting in the paginated facet view. You can click it, but the sort order does not change.

[cbeer]

I see it. We're using the generic facet.sort parameter in Blacklight::SolrHelper#solr_facet_params (https://github.com/projectblacklight/blacklight/blob/master/lib/blacklight/solr_helper.rb#L450), which is overridden by the more specific f.field.facet.sort. I don't see why we shouldn't change #solr_facet_params to use the more specific form.

Here's the offending section:

    solr_params['facet.offset'] = input[  Blacklight::Solr::FacetPaginator.request_keys[:offset]  ].to_i # will default to 0 if nil
    solr_params['facet.sort'] = input[  Blacklight::Solr::FacetPaginator.request_keys[:sort] ]     
    solr_params[:rows] = 0

    return solr_params
  end

I think we can turn that into:

    solr_params["f.#{facet_field}.facet.offset"] = input[  Blacklight::Solr::FacetPaginator.request_keys[:offset]  ].to_i # will default to 0 if nil
    solr_params["f.#{facet_field}.facet.sort"] = input[  Blacklight::Solr::FacetPaginator.request_keys[:sort] ]     
    solr_params[:rows] = 0

    return solr_params
  end

If you (or another committer) want to pull together a patch for master with some tests (and, let me know if you want this backported to some other version.. it should be easy enough to apply elsewhere), that might speed things up. Else, I'll try to get to it in the next week.

[devn]

I submitted a patch. I cannot get tests to run so there's no test included in my patch. If you want to backport to 3.5.0 that'd be cool.

[devn]

Tried the above suggestion in the patch I submitted, but it is now actually more broken than before: When you click the button to sort by count in the pagination view the buttons are actually removed from the page and the sort order does not change.

[devn]

I based the above commit off of the release-3.5 branch. Again this is untested, but it looks like this will fix it.

[cbeer]

I got my symbols and strings mixed up in my example code. ed66fd9 should be right.