Blacklight JSON API for search and show #588
Conversation
|
Maybe I'm dense here (it's also 4am and I'm reading this PR on my phone), but wouldn't the more "Blacklight" way to do this utilize the document extension framework? |
|
@MrDys The document extension framework would work for the show page, but not for the search page, where most of the work in this PR resides. There is only one line of code dedicated to rendering the show page: format.json { render json: {response: {document: @document}}}Mostly it's about crafting the response itself to be a hash with |
| @@ -32,16 +32,20 @@ def search_action_url | |||
| # get search results from the solr index | |||
| def index | |||
|
|
|||
| extra_head_content << view_context.auto_discovery_link_tag(:rss, url_for(params.merge(:format => 'rss')), :title => t('blacklight.search.rss_feed') ) | |||
There was a problem hiding this comment.
Aren't these links appropriate for all response types?
There was a problem hiding this comment.
extra_head_content is rendered in app/views/catalog/index.html.erb, so I don't think so.
There was a problem hiding this comment.
Oh, got it. I think I mixed this up with something as a Link: header
|
Who's the consumer of this API (and, why should they like ours more than e.g. the native Solr one)? |
|
Good point about who's the consumer. In our case, it's the "UI" person who's wiring in graphs and other wizbang JSONy componentry. It's nice to have the Blacklight "wrapper" around or flavor of the Solr response. I also would like a Solr "pass through" for JSON (or even other formats) using the same Blacklight constrainting for the request and/or session, but that's a separate issue for different play ground kinds of use cases. |
|
@cbeer I'm envisioning a Angular/Ember front end for a hydra application. I want Blacklight to filter access to the objects that the consumer has access to. |
| @@ -5,28 +5,7 @@ module Blacklight::CatalogHelperBehavior | |||
| # it translates to a Kaminari-paginatable | |||
| # object, with the keys Kaminari views expect. | |||
| def paginate_params(response) | |||
|
|
|||
There was a problem hiding this comment.
We should rebase this patch on top of master in light of #595
Blacklight JSON API for search and show
No description provided.