Bookmark cucumber test passing despite not working

[jcoyne]

When I run:

RAILS_ROOT=spec/internal BUNDLE_GEMFILE=spec/internal/Gemfile bundle exec cucumber features/bookmarks.feature:55

The test passes. The core assertion here: https://github.com/projectblacklight/blacklight/blob/master/features/bookmarks.feature#L61

Is not actually testing what it says it's testing because this step doesn't do anything with the button name that is passed to it: https://github.com/projectblacklight/blacklight/blob/master/features/step_definitions/search_steps.rb#L34-L36

I'm thinking we ought to just remove this test. What do you all think?

[cbeer]

fixed?

[jcoyne]

Nope, I just marked it pending. https://github.com/projectblacklight/blacklight/blob/master/spec/features/bookmarks_spec.rb#L43