New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert front end to boostrap3 #640
Conversation
I've (mostly) fixed all these styling issues in 968942e (bootstrap3 branch). In that branch, I also merged blacklight-core back into blacklight. If we're only shipping one theme, I'm not sure the added maintenance overhead is worth the effort. Since we're doing this as Blacklight 5.x, we should be able to add something in the release notes for old installs and add it as a generator step for new installs. Thoughts? There are a couple minor alignment issues (and our blacklight logo doesn't look great on black), but here's what I have as of 968942e: |
Deployed bootstrap3 branch to http://bootstrap3.demo.projectblacklight.org/ If 93393fc2 sounds good, @jcoyne, I'll squash those commits and send it as a pull request. |
Can the bootstrap 3 branch keep the responsive functionality where the facets sidebar collapses to a button and text at small widths? |
Thanks. Fixed in e05ac85, using mostly bootstrap machinery, even. |
[x ] Facet counts should be aligned right, not left. |
Replaced by #643 |
Question: For the search box, for the field popup, you chose an ordinary un-styled select inside an Are there reasons you chose this over a styled bootstrap select, or even a |
Instead of a styled bootstrap select: because I couldn't get it to work right. From IRC this morning, I think @MrDys is looking at making it work with an input-group-button. |
right on, thanks. I also just noticed the bootstrap docs for input groups specifically warn: "Avoid using elements here as they cannot be fully styled in WebKit browsers." The docs instead use 'button groups' to sort of simulate elements, at least visually, although I'm not sure how you'd make them accessible and degradable and such. I wonder if it might be better to use a standard styled bootstrap select, but not in an 'input group' to be flush with the text box, the way the current bootstrap 2 demo.projectblacklight.org does. |
No description provided.