Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert front end to boostrap3 #640

Closed
wants to merge 1 commit into from
Closed

Convert front end to boostrap3 #640

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Nov 21, 2013

No description provided.

@ghost ghost assigned cbeer Nov 23, 2013
@cbeer
Copy link
Member

cbeer commented Nov 23, 2013

There's a bunch of nasty UI after the bootstrap 3 update. I'll look at fixing some of them up (in fact, I think most of these patterns now have bootstrap 3 equivalents that we should use)

[x] Search box should be joined to the submit button, field selector:
screen shot 2013-11-23 at 9 24 59

[x] Show actions is misaligned:
screen shot 2013-11-23 at 9 25 13

[x] Pagination controls are unstyled:
screen shot 2013-11-23 at 9 25 28

[x] Sort and per-page controls should use Bootstrap 3 styling:
screen shot 2013-11-23 at 9 25 24

[x] Facets should have twiddles:
screen shot 2013-11-23 at 9 25 03

[x] The facet value alignment is all wrong:
screen shot 2013-11-23 at 9 25 08

Responsive header design.. isn't..:
screen shot 2013-11-23 at 9 42 31

@cbeer
Copy link
Member

cbeer commented Nov 24, 2013

I've (mostly) fixed all these styling issues in 968942e (bootstrap3 branch).

In that branch, I also merged blacklight-core back into blacklight. If we're only shipping one theme, I'm not sure the added maintenance overhead is worth the effort. Since we're doing this as Blacklight 5.x, we should be able to add something in the release notes for old installs and add it as a generator step for new installs. Thoughts?

There are a couple minor alignment issues (and our blacklight logo doesn't look great on black), but here's what I have as of 968942e:

screen shot 2013-11-23 at 16 54 07

@cbeer
Copy link
Member

cbeer commented Nov 24, 2013

Deployed bootstrap3 branch to http://bootstrap3.demo.projectblacklight.org/

If 93393fc2 sounds good, @jcoyne, I'll squash those commits and send it as a pull request.

@jronallo
Copy link
Member

Can the bootstrap 3 branch keep the responsive functionality where the facets sidebar collapses to a button and text at small widths?

@cbeer
Copy link
Member

cbeer commented Nov 24, 2013

Thanks. Fixed in e05ac85, using mostly bootstrap machinery, even.

@cbeer
Copy link
Member

cbeer commented Nov 25, 2013

Couple more TODOs:
[x ] Email

screen shot 2013-11-24 at 17 06 22

[x] SMS
screen shot 2013-11-24 at 17 06 26

@cbeer
Copy link
Member

cbeer commented Nov 25, 2013

[x ] Facet counts should be aligned right, not left.

@cbeer
Copy link
Member

cbeer commented Nov 25, 2013

Replaced by #643

@cbeer cbeer closed this Nov 25, 2013
@cbeer cbeer deleted the plugable_front_end branch November 25, 2013 18:14
@jrochkind
Copy link
Member

Question: For the search box, for the field popup, you chose an ordinary un-styled select inside an input-group-addon.

Are there reasons you chose this over a styled bootstrap select, or even a input-group-button with a dropdown?

@cbeer
Copy link
Member

cbeer commented Nov 25, 2013

Instead of a styled bootstrap select: because I couldn't get it to work right.

From IRC this morning, I think @MrDys is looking at making it work with an input-group-button.

@jrochkind
Copy link
Member

right on, thanks. I also just noticed the bootstrap docs for input groups specifically warn: "Avoid using elements here as they cannot be fully styled in WebKit browsers." The docs instead use 'button groups' to sort of simulate elements, at least visually, although I'm not sure how you'd make them accessible and degradable and such.

I wonder if it might be better to use a standard styled bootstrap select, but not in an 'input group' to be flush with the text box, the way the current bootstrap 2 demo.projectblacklight.org does.

@cbeer cbeer mentioned this pull request Nov 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants