Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add facet limit unless it is known. #1989

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Do not add facet limit unless it is known. #1989

merged 3 commits into from
Apr 27, 2022

Commits on Apr 27, 2022

  1. Verify not adding facet limit unless it is configured. 

    This commit updates the code that adds facet limits from user supplied
parameters so that facets are only added if they have been configured
as facet fields.  This is done to allow for multiple faceted searches to
be defined in the same URL while still keeping the facets separate.
    @dkinzer @barmintor
    dkinzer authored and barmintor committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    a9031a1 View commit details
    Browse the repository at this point in the history

  2. verify constraints component does not render unconfigured facets

    @barmintor
    barmintor committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    8f5a2cc View commit details
    Browse the repository at this point in the history

  3. remove negative expectation feature spec in favor of component spec

    @barmintor
    barmintor committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    bccdbc1 View commit details
    Browse the repository at this point in the history