Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing pagination a11y translations #1991

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Adds missing pagination a11y translations #1991

merged 2 commits into from
Oct 25, 2018

Conversation

mejackreed
Copy link
Contributor

Merge #1970 first.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 94.785% when pulling 75ba139 on add-missing-pagination-keys into c1ce34f on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 94.785% when pulling 75ba139 on add-missing-pagination-keys into c1ce34f on master.

@coveralls
Copy link

coveralls commented Oct 25, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 94.783% when pulling 75ba139 on add-missing-pagination-keys into c1ce34f on master.

@barmintor barmintor added this to In Progress in Blacklight 7.0 Release Oct 25, 2018
barmintor
barmintor approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@barmintor barmintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes generally approved in #1970, thanks for the translation to GTM

@barmintor barmintor merged commit df7e862 into master Oct 25, 2018
@barmintor barmintor mentioned this pull request Oct 25, 2018
Closed
@mejackreed mejackreed deleted the add-missing-pagination-keys branch October 25, 2018 16:58
@barmintor barmintor moved this from In Progress to Done in Blacklight 7.0 Release Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmintor barmintor barmintor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Blacklight 7.0 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mejackreed @coveralls @barmintor @adamjarling