Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this class appears to be not in use in anymore #2104

Closed
wants to merge 1 commit into from
Closed

this class appears to be not in use in anymore #2104

wants to merge 1 commit into from

Conversation

cdmo
Copy link
Member

@cdmo cdmo commented May 23, 2019

Small potatoes, but this appears to be a small bit of extra code that might be worth removing

Copy link
Member

@cbeer cbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be intended as an extension point for downstream applications to use to provide styling or other behaviors.

@cdmo
Copy link
Member Author

cdmo commented May 23, 2019

I guess I was thinking it was a bit odd that this one element has a class attached, but others don't have extra classes with no style attached. The rest of the codebase seems to assume you'll override the view (or add classes through a helper method like LayoutHelper::sidebar_classes). The naming convention of the class is a bit odd too compared to all the other classes/ids I've encountered so far. Just seemed like a thing that got missed, but if it's needed/wanted, of course just close the PR. Thanks.

@bess bess closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants