adjusts search result bookmark, thumbnail padding #2125
Conversation
| @@ -13,7 +13,7 @@ | |||
| // bookmarks checkbox on index, give it some | |||
| // lower margin when it collapses | |||
| .index-document-functions { | |||
| margin-bottom: ($line-height-base / 2); | |||
There was a problem hiding this comment.
I suspect we want to use $spacing and its variants here, instead of hard-coding a rem value?
There was a problem hiding this comment.
Is spacing in terms of rem values? That is another option. You will see some hard-coded rem values in Bootstrap 4 variables file for spacing/padding though, it's not unheard of.
Using $spacing is a way of making sure you are using consistent spacing values -- but if we just want to make it consistent with what was in earlier bootstrap 3 versions of blacklight (where things may NOT have been consistent with each other) without setting up that whole "$spacing regime")...
I think in this case using hard-coded rem may be legit, fixing the bug that was there before without making anything worse than it was before.
There was a problem hiding this comment.
Ok I converted the rem values to functions of $spacer. $spacer defaults to 0.5rem.
tampakis
force-pushed
the
2124-line-height-base
branch
from
bf9d592
to
7621776
Compare
camillevilla
dismissed
cbeer’s stale review
@tampakis made requested changes.
Closes #2124