Only show search context controls if the current context matches the … #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmo
reviewed
Aug 12, 2020
cdmo
reviewed
Aug 12, 2020
| @@ -68,7 +68,7 @@ def link_to_next_document(next_document) | |||
| # session_tracking_params(SolrDocument.new(id: 123), 7) | |||
| # => { data: { :'context-href' => '/catalog/123/track?counter=7&search_id=999' } } | |||
| def session_tracking_params document, counter | |||
| path = session_tracking_path(document, per_page: params.fetch(:per_page, search_session['per_page']), counter: counter, search_id: current_search_session.try(:id)) | |||
| path = session_tracking_path(document, per_page: params.fetch(:per_page, search_session['per_page']), counter: counter, search_id: current_search_session.try(:id), document_id: document.id) | |||
There was a problem hiding this comment.
Without a safe navigation operator you get a id not defined on nil error when you click on the first result.
Suggested change
| path = session_tracking_path(document, per_page: params.fetch(:per_page, search_session['per_page']), counter: counter, search_id: current_search_session.try(:id), document_id: document.id) | |
| path = session_tracking_path(document, per_page: params.fetch(:per_page, search_session['per_page']), counter: counter, search_id: current_search_session.try(:id), document_id: document&.id) |
|
I am on 7.5.1 for my purposes and we have some local differences in our placement of where we render |
cdmo
force-pushed
the
search-context-idea
branch
from
c31387f
to
73c7a8b
Compare
|
Just rebased and then added a rubocop |
cdmo
force-pushed
the
search-context-idea
branch
from
4e6a735
to
c47b337
Compare
|
I took the liberty of fleshing this PR out some more, hope that's okay. I wasn't sure of a couple of thing: 1) if the |
Co-authored-by: Charlie Morris <523381+cdmo@users.noreply.github.com>
…back to search" buttons
cbeer
force-pushed
the
search-context-idea
branch
from
0b94ff3
to
2ca1c96
Compare
mejackreed
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…current document
Maybe helps address or obscure the problems from #2295?