Silence deprecation on search_fields within the blacklight code #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
reviewed
Jul 25, 2022
| @@ -67,6 +67,10 @@ json.included do | |||
| end | |||
| end | |||
|
|
|||
| search_fields = blacklight_config.search_fields.values. | |||
There was a problem hiding this comment.
I think it's possible downstream applications have overridden the search_fields helper, so the best we can do is wrap it in Deprecation.silence(Blacklight::ConfigurationHelperBehavior)?
There was a problem hiding this comment.
Good point! Wrap this bit of code then? I will try that.
hackartisan
force-pushed
the
backport-search_fields-jbuilder
branch
from
a4fae43
to
c2d101c
Compare
This avoids deprecation warnings downstream while ensuring we preserve overridden behavior until the deprecation goes into effect. refs projectblacklight@009a426
hackartisan
force-pushed
the
backport-search_fields-jbuilder
branch
from
c2d101c
to
eaaf8c2
Compare
hackartisan
changed the title
|
@cbeer how's this? silences deprecations when I try it with my app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This silences deprecation warnings downstream.
refs 009a426