Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Blacklight::Base #2943

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Remove unnecessary Blacklight::Base #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions app/controllers/concerns/blacklight/base.rb
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion app/controllers/concerns/blacklight/catalog.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ module Blacklight::Catalog
# MimeResponds is part of ActionController::Base, but not ActionController::API
include ActionController::MimeResponds

include Blacklight::Base
include Blacklight::Configurable
include Blacklight::SearchContext
include Blacklight::Searchable

# The following code is executed when someone includes blacklight::catalog in their
Expand Down
4 changes: 2 additions & 2 deletions spec/controllers/blacklight/base_spec.rb → spec/controllers/blacklight/catalog_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# frozen_string_literal: true

RSpec.describe Blacklight::Base do
RSpec.describe Blacklight::Catalog do
subject { controller }

let(:controller) { (Class.new(ApplicationController) { include Blacklight::Base }).new }
let(:controller) { (Class.new(ApplicationController) { include Blacklight::Catalog }).new }

describe "#search_state" do
subject { controller.send(:search_state) }
Expand Down