Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clearfix to #previousNextDoc, for small screens #675

Merged
merged 1 commit into from Jan 9, 2014

Conversation

jrochkind
Copy link
Member

On very small screens, on the Catalog#show, the floated "back to search"/"start over" escape their bounding box, and wind up below the bottom border, and too close to the next line:

prev-next-doc-overflow

Fixed simply by adding the .clearfix to the #previousNextDocument div:

prev-next-doc-clearfixed

Arguably, additional tweaks should be done, to keep these from being floated right on small screens, or even to hide them entirey on small screens (?), I'm not really sure, and the clearfix seems a good idea regardless, I think?

@cbeer
Copy link
Member

cbeer commented Jan 9, 2014

+1 to the other styling suggestions. Want to do that first, or get this merged in as-is?

@jrochkind
Copy link
Member Author

I'd go with merging this first -- I'm honestly not sure the best way to do the other stuff (both in terms of what it should look like, and how to implement it properly), so figured to just start with this to fix the worst problem.

@jrochkind
Copy link
Member Author

I'm not sure at exactly what width-point the media query would do something different with those -- it should really do something different at the point the float 'wraps', but there's no way to do that with floats. Perhaps it should be using bootstrap grid columns instead of floats? You'd probably still need to change the text-align to left instead of right at some breakpoint, but at least you'd know the breakpoint that the bootstrap grid collapses.

cbeer added a commit that referenced this pull request Jan 9, 2014
add clearfix to #previousNextDoc, for small screens
@cbeer cbeer merged commit aa8dbe9 into projectblacklight:master Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants