Two errors in custom merge

[atz]

Bad check at:
https://github.com/projectblacklight/blacklight_advanced_search/blob/master/lib/blacklight_advanced_search.rb#L30

if new_value.respond_to?(:blank) && new.blank?

:blank vs. :blank? and new_value vs. new

Looks like the new/new_value error was introduced here: 6d3b49a#diff-4961a18d7c088f36dc4f670c73ae74a6R30

And the other in 2011 or before (so far back, I don’t care anymore). Got test coverage?

[atz]

Maybe time to undo that whole method now that BL doesn't have to support rails3?
projectblacklight/blacklight#827

[atz]

Note: when I fix this error, the behavior further diverges from Rails deep_merge because

false.blank? ==> true
true.blank? ==> false

So any boolean false values in the overlaying hash are ignored. But when set to true the same values are enforced. This doesn't make any sense, but Rails has chosen.

[mjgiarlo]

👀