Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset generator fails on Blacklight 8 #210

Open
jcoyne opened this issue Oct 7, 2022 · 4 comments · May be fixed by #211
Open

asset generator fails on Blacklight 8 #210

jcoyne opened this issue Oct 7, 2022 · 4 comments · May be fixed by #211

Comments

@jcoyne
Copy link
Member

jcoyne commented Oct 7, 2022

    generate  blacklight_range_limit:assets
       rails  generate blacklight_range_limit:assets
      insert  app/assets/stylesheets/application.css
The file /Users/jcoyne85/workspace/projectblacklight/arclight/.internal_test_app/app/assets/javascripts/application.js does not appear to exist

https://github.com/projectblacklight/blacklight_range_limit/blob/main/lib/generators/blacklight_range_limit/assets_generator.rb#L35-L43

This probably happens if the app is not using sprockets for javascript (importmap-rails).

@jrochkind
Copy link
Member

jrochkind commented Oct 10, 2022

"bootstrap 8" -- I think is not a thing. Did you mean Blacklight 8.x? Off the current git head? With Rails... 7.something? A bit more fleshed out reproduction instructions might be helpful if possible!

@jcoyne
Copy link
Member Author

jcoyne commented Oct 10, 2022

Yes, this is blacklight as installed from git:

gem 'blacklight', github: 'projectblacklight/blacklight'

@jrochkind
Copy link
Member

jrochkind commented Oct 10, 2022

Thanks! Should the title of this issue say "Blacklight 8" instead of "bootstrap 8"? Your reproduction was with rails 7?

@jcoyne jcoyne changed the title asset generator fails on bootstrap 8 asset generator fails on Blacklight 8 Oct 10, 2022
@jcoyne
Copy link
Member Author

jcoyne commented Oct 10, 2022

@jrochkind Yes. I updated. Thanks for catching my typo.

@jcoyne jcoyne linked a pull request Oct 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants