Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprockets require vs. SCSS @import #55

Open
atz opened this issue Nov 2, 2016 · 1 comment
Open

Sprockets require vs. SCSS @import #55

atz opened this issue Nov 2, 2016 · 1 comment
Labels
bundled-assets JS and CSS Issues

Comments

@atz
Copy link
Member

atz commented Nov 2, 2016

https://github.com/rails/sass-rails#important-note

Sprockets provides some directives that are placed inside of comments called require, require_tree, and require_self. DO NOT USE THEM IN YOUR SASS/SCSS FILES. They are very primitive and do not work well with Sass files. Instead, use Sass's native @import directive which sass-rails has customized to integrate with the conventions of your Rails projects.

The blacklight_range_limit generator will insert require statements in SCSS files. Apparently, this is to be avoided.
@cbeer
Copy link
Member

cbeer commented Nov 2, 2016

👍 I think we've fixed this in blacklight, and it would be great if we fixed this everywhere.

@jkeck jkeck mentioned this issue Dec 13, 2017
Merged
@barmintor barmintor added the bundled-assets JS and CSS Issues label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bundled-assets JS and CSS Issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atz @cbeer @barmintor