Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add signoff support #31

Closed
OdinVex opened this issue Mar 9, 2022 · 6 comments
Closed

Feature Request: Add signoff support #31

OdinVex opened this issue Mar 9, 2022 · 6 comments

Comments

@OdinVex
Copy link

OdinVex commented Mar 9, 2022

I've manually patched UEGitPlugin to add signoff. (-s param for commits)

@mastercoms
Copy link
Member

You can config this in git: git config commit.gpgsign true

@OdinVex
Copy link
Author

OdinVex commented Mar 10, 2022

That has nothing to do with signoff. That's for signing with GPG.

Edit: -S signs with GPG (or you can use gpgsign config), -s signsoff with a message in commit (appended), such as "Signed-off by: Signer"

@mastercoms
Copy link
Member

mastercoms commented Mar 10, 2022

Oh sorry, I misread -s for -S :) sure this sounds like something useful

@mastercoms mastercoms reopened this Mar 10, 2022
@OdinVex
Copy link
Author

OdinVex commented Mar 11, 2022

Oh sorry, I misread -s for -S :) sure this sounds like something useful

That happens to me all the time on GitHub/Arch AUR, heh. Indeed, it's helpful, I've already added it into my own build.

@mastercoms
Copy link
Member

Unfortunately, I'm not sure it's possible to modify the source control submit window for this feature. How did you end up adding it in your modification?

@mastercoms
Copy link
Member

Closing for inactivity, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants