Skip to content

Commit

Permalink
Fix handling of VALIDARCHES for release
Browse files Browse the repository at this point in the history
  • Loading branch information
caseydavenport committed Jan 14, 2022
1 parent 958a134 commit 220d04c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
6 changes: 0 additions & 6 deletions hack/release/pkg/builder/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ var (
"us.gcr.io/projectcalico-org",
}

// Architectures to build as part of a release.
// Left blank defaults to auto-detect each image's supported architectures.
architectures = []string{}

// Git configuration for publishing to GitHub.
organization = "projectcalico"
repo = "calico"
Expand Down Expand Up @@ -311,7 +307,6 @@ func (r *ReleaseBuilder) buildContainerImages(ver string) error {
env := append(os.Environ(),
fmt.Sprintf("VERSION=%s", ver),
fmt.Sprintf("DEV_REGISTRIES=%s", strings.Join(registries, " ")),
fmt.Sprintf("VALIDARCHES=%s", strings.Join(architectures, " ")),
)

for _, dir := range releaseDirs {
Expand Down Expand Up @@ -381,7 +376,6 @@ func (r *ReleaseBuilder) publishContainerImages(ver string) error {
"RELEASE=true",
"CONFIRM=true",
fmt.Sprintf("DEV_REGISTRIES=%s", strings.Join(registries, " ")),
fmt.Sprintf("VALIDARCHES=%s", strings.Join(architectures, " ")),
)

for _, dir := range releaseDirs {
Expand Down
2 changes: 1 addition & 1 deletion lib.Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ endif
# list of arches *not* to build when doing *-all
# until s390x works correctly
EXCLUDEARCH ?= s390x
VALIDARCHES ?= $(filter-out $(EXCLUDEARCH),$(ARCHES))
VALIDARCHES = $(filter-out $(EXCLUDEARCH),$(ARCHES))

# BUILDARCH is the host architecture
# ARCH is the target architecture
Expand Down

0 comments on commit 220d04c

Please sign in to comment.