Remove ancient migration code #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 21, 2022 17:14
There is similar code at libcalico-go/lib/upgrade/migrator/clients/v1/compat, so I guess backend/compat is an obsolete earlier version of that.
marvin-tigera
added
docs-pr-required
nelljerram
added
docs-not-required
caseydavenport
approved these changes
Jan 21, 2022
|
This has had 4 failed CI runs, but with different failures in each run:
Since all of the tests passed in at least one run, I assume these were all flakes. (We really should try to fix these, to save CI resources.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes ancient migration code for migrating from Calico v1 format data stored in an etcd v2 datastore - i.e. from a Calico installation before v3.0. There was already nothing in Calico's code or docs to provide a frontend/UI/CLI/whatever for using that code. It's theoretically conceivable that a 3rd party somewhere is importing some of the removed code to implement their own migration, but exceedingly unlikely.
Release Note