Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version checking compatibility. #6064

Merged
merged 1 commit into from May 11, 2022

Conversation

lou-lan
Copy link
Contributor

@lou-lan lou-lan commented May 11, 2022

Description

Related issues/PRs

Fixs #6027

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Ignore v prefix when comparing cluster and client version in calicoctl

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@lou-lan lou-lan requested a review from a team as a code owner May 11, 2022 04:53
@marvin-tigera marvin-tigera added this to the Calico v3.24.0 milestone May 11, 2022
@marvin-tigera marvin-tigera added docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small) labels May 11, 2022
@CLAassistant
Copy link

CLAassistant commented May 11, 2022

CLA assistant check
All committers have signed the CLA.

@caseydavenport caseydavenport added the docs-not-required Docs not required for this change label May 11, 2022
@marvin-tigera marvin-tigera removed the docs-pr-required Change is not yet documented label May 11, 2022
@caseydavenport
Copy link
Member

/sem-approve

@marvin-tigera marvin-tigera merged commit 3c91e9f into projectcalico:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants