Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.24] Auto pick #6513: kube-controllers health check: timeout, and report any errors #6514

Conversation

caseydavenport
Copy link
Member

Cherry pick of #6513 on release-v3.24.

#6513: kube-controllers health check: timeout, and report any errors

Original PR Body below

Description

  • We never timeout the /healthz call, meaning it might take a while before we retry if the connection gets blackholed.
  • We were logging out a nil error - instead, get the error from the HTTP call.

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix nil error logged from kube-controllers health reporter
Fix that kube-controllers health checks didn't include a timeout on HTTP calls

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@caseydavenport caseydavenport requested a review from a team as a code owner August 9, 2022 00:45
@caseydavenport caseydavenport added docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small) labels Aug 9, 2022
@marvin-tigera marvin-tigera added this to the Calico v3.24.0 milestone Aug 9, 2022
@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for calico-v3-24 canceled.

Name Link
🔨 Latest commit 4c28bed
🔍 Latest deploy log https://app.netlify.com/sites/calico-v3-24/deploys/62f1ae26b7175a0008dbf79f

@caseydavenport caseydavenport merged commit de998b4 into projectcalico:release-v3.24 Aug 9, 2022
@caseydavenport caseydavenport deleted the auto-pick-of-#6513-origin-release-v3.24 branch August 9, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants