-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenStack: Support newer, more scalable version of etcd server #7147
Merged
mgleung
merged 8 commits into
projectcalico:master
from
nelljerram:etcd3-gateway-update
Jan 18, 2023
Merged
OpenStack: Support newer, more scalable version of etcd server #7147
mgleung
merged 8 commits into
projectcalico:master
from
nelljerram:etcd3-gateway-update
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
docs-pr-required
Change is not yet documented
release-note-required
Change has user-facing impact (no matter how small)
labels
Jan 5, 2023
nelljerram
added
docs-completed
Docs PR has been merged for this change
and removed
docs-pr-required
Change is not yet documented
labels
Jan 5, 2023
etcd prior to v3.4.20 had a scalability bug that limited the number of possible simultaneous client watches, and hence the maximum number of cluster nodes in a Calico+OpenStack installation. Hence we'd like to support etcd v3.4.20 and later. However, etcd v3.4 only supports URL paths with '/v3beta/' or '/v3/', and not the '/v3alpha/' that is hardcoded in our documented version of the etcd3gw package (previously known as etcd3-gateway). Hence we also need to: - document using a newer etcd3gw that supports the newer URL paths, namely version 1.0.1 - add a Calico config option to control that (bearing in mind that etcd3gw's default is still '/v3alpha/', and that some users might still be using older etcd servers, and so we can't just hardcode a newer setting).
nelljerram
force-pushed
the
etcd3-gateway-update
branch
from
January 17, 2023 17:37
618ca94
to
d30e645
Compare
nelljerram
added
docs-pr-required
Change is not yet documented
and removed
docs-completed
Docs PR has been merged for this change
labels
Jan 17, 2023
nelljerram
added a commit
to nelljerram/docs
that referenced
this pull request
Jan 17, 2023
Please see projectcalico/calico#7147 for more detail.
lwr20
approved these changes
Jan 18, 2023
mgleung
reviewed
Jan 18, 2023
mgleung
approved these changes
Jan 18, 2023
ctauchen
pushed a commit
to tigera/docs
that referenced
this pull request
Jan 19, 2023
Please see projectcalico/calico#7147 for more detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs-completed
Docs PR has been merged for this change
release-note-required
Change has user-facing impact (no matter how small)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
etcd prior to v3.4.20 had a scalability bug that limited the number of possible simultaneous client watches, and hence the maximum number of cluster nodes in a Calico+OpenStack installation. Hence we'd like to support etcd v3.4.20 and later.
However, etcd v3.4 only supports URL paths with '/v3beta/' or '/v3/', and not the '/v3alpha/' that is hardcoded in our documented version of the etcd3gw package (previously known as etcd3-gateway). Hence we also need to:
document using a newer etcd3gw that supports the newer URL paths, namely version 1.0.1
add a Calico config option to control that (bearing in mind that etcd3gw's default is still '/v3alpha/', and that some users might still be using older etcd servers, and so we can't just hardcode a newer setting).
Release Note