Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPF] Topology Aware Hints implementation #7241

Merged
merged 11 commits into from Feb 17, 2023
Merged

[BPF] Topology Aware Hints implementation #7241

merged 11 commits into from Feb 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2023

Description

fixes 7041

Running Calico with eBPF dataplane enabled and external kube-proxy disabled in the Kubernetes clusters on AWS. Would like to optimize the inter-AZ network costs and implement the solution offered by k8s Topology aware hints. It is understood that this feature is enabled in k8s 1.24 onwards.

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: Topology Aware Hints supported when/where provided by k8s.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@ghost ghost self-requested a review as a code owner January 27, 2023 11:43
@marvin-tigera marvin-tigera added this to the Calico v3.26.0 milestone Jan 27, 2023
@marvin-tigera marvin-tigera added docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small) labels Jan 27, 2023
@ghost ghost mentioned this pull request Jan 27, 2023
3 tasks
@ghost ghost changed the title DRAFT WIP BPF 2079 Topology Aware Hints implementation DRAFT BPF 2079 Topology Aware Hints implementation Jan 27, 2023
@ghost ghost marked this pull request as draft January 27, 2023 18:39
Copy link
Contributor

@tomastigera tomastigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok, i think we should only pass in the zone not all the labels, see the comments.

felix/dataplane/driver.go Outdated Show resolved Hide resolved
felix/bpf/proxy/topology.go Outdated Show resolved Hide resolved
felix/bpf/proxy/topology_test.go Outdated Show resolved Hide resolved
felix/bpf/proxy/syncer.go Outdated Show resolved Hide resolved
felix/bpf/proxy/syncer.go Outdated Show resolved Hide resolved
felix/bpf/proxy/kube-proxy.go Outdated Show resolved Hide resolved
felix/bpf/proxy/syncer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tomastigera tomastigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one possibly spammy log

felix/bpf/proxy/syncer.go Outdated Show resolved Hide resolved
@tomastigera tomastigera changed the title DRAFT BPF 2079 Topology Aware Hints implementation [BPF] Topology Aware Hints implementation Feb 1, 2023
@ghost
Copy link
Author

ghost commented Feb 1, 2023

/merge-when-ready

@ghost ghost added kind/enhancement area/bpf eBPF Dataplane issues and removed docs-pr-required Change is not yet documented labels Feb 2, 2023
@marvin-tigera marvin-tigera added the docs-pr-required Change is not yet documented label Feb 2, 2023
@tomastigera tomastigera removed the docs-pr-required Change is not yet documented label Feb 3, 2023
@marvin-tigera marvin-tigera added the docs-pr-required Change is not yet documented label Feb 3, 2023
@tomastigera tomastigera added docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented labels Feb 3, 2023
@ghost ghost marked this pull request as ready for review February 7, 2023 09:31
@ghost ghost requested a review from tomastigera February 9, 2023 12:08
@tomastigera
Copy link
Contributor

pls couold you rebase this branch on the current master?

@ghost
Copy link
Author

ghost commented Feb 14, 2023

pls could you rebase this branch on the current master?
Done

Copy link
Contributor

@tomastigera tomastigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tomastigera tomastigera merged commit f8b7d85 into projectcalico:master Feb 17, 2023
@ghost ghost deleted the BPF-2079_TopologyAwareHints_Impl branch February 22, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bpf eBPF Dataplane issues docs-not-required Docs not required for this change kind/enhancement release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use TopologyAwareHints in ebpf kube-proxy
2 participants