Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UID for v3 resources in KDD mode #7291

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Feb 7, 2023

Description

Picking up the fix for #5715. Looks like we adopted this fix in Calico Enterprise already so let's be consistent.

Related issues/PRs

fixes #5715

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix that Calico API server would reuse UUIDs from the underlying CRD objects that underpin the datamodel (thus confusing Kubernetes ownership tracking and ArgoCD).  This will result in the apparent UUIDs of calico "v3" resources changing over upgrade.  This was unavoidable in order to split them from the underlying CRD UUIDs.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@fasaxc fasaxc requested a review from a team as a code owner February 7, 2023 12:00
@marvin-tigera marvin-tigera added this to the Calico v3.26.0 milestone Feb 7, 2023
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Feb 7, 2023
@fasaxc fasaxc added docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented labels Feb 7, 2023
@@ -1,4 +1,4 @@
// Copyright (c) 2017-2019,2021 Tigera, Inc. All rights reserved.
// Copyright (c) 2017-2019,2021-2022 Tigera, Inc. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 2023 now 😁

@fasaxc
Copy link
Member Author

fasaxc commented Feb 8, 2023

/merge-when-ready

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calico Apiserver not delete Resource with OwnerReference
3 participants