Clean up deprecated+removed cmd line flags #7294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coutinhop
added
release-note-required
coutinhop
requested review from
fasaxc,
mgleung,
caseydavenport,
nelljerram and
song-jiang
Josh-Tigera
reviewed
Feb 7, 2023
| @@ -57,8 +57,6 @@ coreos: | |||
| --cluster-dns=10.100.0.10 \ | |||
| --cluster-domain=cluster.local \ | |||
| --hostname-override=$private_ipv4 \ | |||
| --logtostderr=true \ | |||
| --network-plugin=cni \ | |||
There was a problem hiding this comment.
Was the removal of --network-plugin=cni here intentional? Has it also been deprecated?
There was a problem hiding this comment.
Yes it was intentional, because of this commit: 25a6144 (though I admit I didn't research on which versions exactly this one was deprecated/removed)
mgleung
approved these changes
Feb 13, 2023
3 tasks
mgleung
added a commit
that referenced
this pull request
Apr 3, 2023
…elease-v3.25 [release-v3.25] Auto pick #7294: Clean up deprecated+removed cmd line flags
3 tasks
mgleung
added a commit
that referenced
this pull request
May 1, 2023
…elease-v3.24 [release-v3.24] Auto pick #7294: Clean up deprecated+removed cmd line flags
coutinhop
added a commit
to coutinhop/tigera-docs
that referenced
this pull request
Jun 1, 2023
Remove usage of deprecated '--logtostderr' command line flag in PrepareNode.ps1 scripts (projectcalico/calico#7294 for more details).
5 tasks
ctauchen
pushed a commit
to tigera/docs
that referenced
this pull request
Jun 2, 2023
Remove usage of deprecated '--logtostderr' command line flag in PrepareNode.ps1 scripts (projectcalico/calico#7294 for more details).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://kubernetes.io/docs/concepts/cluster-administration/system-logs/ says these flags were deprecated in v1.23, and seem to have been removed in v1.26, and it also says "Output will always be written to stderr, regardless of the output format."
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.