Using the netlink.NewLinkAttrs to bring default values from kernel #7358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
mgleung
reviewed
Feb 16, 2023
| @@ -76,14 +76,14 @@ func (d *linuxDataplane) DoNetworking( | |||
| } | |||
|
|
|||
| err = ns.WithNetNSPath(args.Netns, func(hostNS ns.NetNS) error { | |||
| la := netlink.NewLinkAttrs() | |||
There was a problem hiding this comment.
I'm worried that using the constructor masks the issue and that we may not realize what values we are intending to set here for TxQLen and NetNsID. Maybe we should add a comment here stating that this constructor should also be setting those values so that we will use the kernel defaults?
There was a problem hiding this comment.
Hmmm idk, the library specifically says to use the constructor or set all the values properly. We would have to comment every usecase. I wish there was no accesses to the individual items and then there would be no such an issue but to use the constructor 🤷♂️ I think this is a great catch! Thanks @radixo !
mgleung
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves a miscommunication between calico-cni and kernel, where a misconfiguration of the structure netlink.LinkAttrs was sending to kernel the information of the queue discipline for the veth pairs generated by calico-cni to be of value 0.
The problem was caused by creating the structure without the function netlink.NewLinkAttrs which initializes the TxQLen to -1, for not sending this info to kernel and getting the kernel default value instead.
For good practices I changed in everywhere the code.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.