Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in custom-resources.yaml manifest #7570

Merged
merged 1 commit into from May 19, 2023

Conversation

krnowak
Copy link
Contributor

@krnowak krnowak commented Apr 19, 2023

These were 404.

@krnowak krnowak requested a review from a team as a code owner April 19, 2023 11:30
@marvin-tigera marvin-tigera added this to the Calico v3.26.0 milestone Apr 19, 2023
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Apr 19, 2023
@fasaxc
Copy link
Member

fasaxc commented Apr 19, 2023

👋 and thanks for the PR. I think those files are autogenerated from the .go files in the operator repo so they need to be updated there first.

@krnowak
Copy link
Contributor Author

krnowak commented Apr 19, 2023

Hi @fasaxc!

The readme in manifests directory tells me that custom-resources.yaml is not auto-generated and as such it should be edited directly. Also, I wasn't sure what to look for in the operator repo. Cursory search for custom-resources, https://docs.tigera.io or https://projectcalico.docs.tigera.io did not yield anything interesting.

@fasaxc
Copy link
Member

fasaxc commented Apr 20, 2023

Ah OK, right you are; I thought it was the CRDs you were editing bu it's the CRs.

@fasaxc
Copy link
Member

fasaxc commented Apr 20, 2023

/sem-approve

@caseydavenport caseydavenport merged commit 021dbe9 into projectcalico:master May 19, 2023
2 checks passed
@caseydavenport
Copy link
Member

Sorry for the delay!

@krnowak krnowak deleted the patch-1 branch May 22, 2023 04:57
@mgleung mgleung added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Nov 16, 2023
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants