Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.26] Fix typha divide by 0 #7585

Merged
merged 1 commit into from Apr 25, 2023

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Apr 24, 2023

Description

Related issues/PRs

Cherry-pick of #7575

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix a divide-by-zero panic in Typha if it received a SIGTERM when it had no active connections.  Since Typha exits in either case, the impact was limited to a scary panic log.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@fasaxc fasaxc added the docs-not-required Docs not required for this change label Apr 24, 2023
@fasaxc fasaxc requested a review from a team as a code owner April 24, 2023 16:40
@marvin-tigera marvin-tigera added this to the Calico v3.27.0 milestone Apr 24, 2023
@marvin-tigera marvin-tigera added the release-note-required Change has user-facing impact (no matter how small) label Apr 24, 2023
@fasaxc fasaxc changed the base branch from master to release-v3.26 April 25, 2023 08:43
@fasaxc fasaxc merged commit 47c416c into projectcalico:release-v3.26 Apr 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants