Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add podsecurity to operator #7732

Merged
merged 4 commits into from Jun 1, 2023
Merged

add podsecurity to operator #7732

merged 4 commits into from Jun 1, 2023

Conversation

si458
Copy link
Contributor

@si458 si458 commented Jun 1, 2023

Description

this allows the operator to work correctly with kubernetes clusters v1.25+ which have pod-security enabled by default (like TalOS)

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Add pod security standard annotation to the tigera-operator namespace for Kubernetes 1.25+

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@si458 si458 requested a review from a team as a code owner June 1, 2023 16:44
@marvin-tigera marvin-tigera added this to the Calico v3.27.0 milestone Jun 1, 2023
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Jun 1, 2023
@CLAassistant
Copy link

CLAassistant commented Jun 1, 2023

CLA assistant check
All committers have signed the CLA.

@caseydavenport
Copy link
Member

Thanks for the PR! This file is actually auto-generated.

You'll need to update the source file in charts/tigera-operator and then run make gen-manifests to update all of the generated manifests that use this component.

@si458
Copy link
Contributor Author

si458 commented Jun 1, 2023

Thanks for the PR! This file is actually auto-generated.

You'll need to update the source file in charts/tigera-operator and then run make gen-manifests to update all of the generated manifests that use this component.

but the namespace section isnt listed anywhere in those folders? ive just checked? so is that bit just auto generated?

all fixed @caseydavenport ! it was in the generate.sh file! as its hard coded!
it should really be moved to its own yaml file maybe in future!

@caseydavenport
Copy link
Member

Whoops! You're right, sorry for leading you in (slightly) the wrong direction 😅

@caseydavenport
Copy link
Member

/sem-approve

@marvin-tigera marvin-tigera merged commit 5b8f737 into projectcalico:master Jun 1, 2023
2 checks passed
@si458 si458 deleted the patch-1 branch June 1, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-pr-required Change is not yet documented merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants