Run yoga devstack tests #7753
Merged
Run yoga devstack tests #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
nelljerram
added
docs-not-required
marvin-tigera
added
release-note-required
nelljerram
added
docs-not-required
lwr20
reviewed
Jun 8, 2023
|
|
||
| sudo -u stack -H -E bash -x <<'EOF' |
There was a problem hiding this comment.
Is it worth a little comment to explain why this is here twice? It does look odd, but I understand from the explanation in the PR why its here :)
|
I'm sorry but I failed delete the branch after merging the pull request. |
nelljerram
pushed a commit
to nelljerram/calico
that referenced
this pull request
Jun 8, 2023
…ck-tests Run yoga devstack tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since doing the work for a DevStack setup with OpenStack Yoga - #7625 - we've had a successful DevStack setup in our CI, but haven't actually been running any tests! A quick way of seeing this is that the CI job only takes 15 minutes when it should take about 25. Obviously it can also be seen in the logs.
This change brings back the tests by splitting a single
sudo -u stack -H -E bash -x <<'EOF'invocation, in networking-calico/devstack/bootstrap.sh, into two: one for the setup and one for the tests. The presumed explanation for the problem is that something in the setup was closing stdin, which meant that bash would not read further commands after the exit of the./stack.shline.