BPF: fix that no IP set filter was set at start-of-day. #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
fasaxc
added
docs-not-required
fasaxc
force-pushed
the
fix-ipset-filter
branch
3 times, most recently
from
95e9b23
to
c449c71
Compare
tomastigera
reviewed
Oct 11, 2023
fasaxc
force-pushed
the
fix-ipset-filter
branch
from
c449c71
to
48b2c42
Compare
|
Added a UT with the markups. |
|
/merge-when-ready |
|
OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it. |
tomastigera
reviewed
Oct 12, 2023
fasaxc
force-pushed
the
fix-ipset-filter
branch
from
48b2c42
to
45e34d2
Compare
|
Removing "merge-when-ready" label due to new commits |
fasaxc
force-pushed
the
fix-ipset-filter
branch
2 times, most recently
from
c23261a
to
7c977ea
Compare
In BPF mode, we don't want to program linux IP sets unless we're using "untracked" policy, which is partially implemented in iptables. The filter to prevent IP set programming was only set after a policy churn. - Defer calculation of the filter until CompleteDeferredWork. - Make sure the "dirty" flag is set at start of day so that the programming triggers before the first dataplane apply().
Includes cleanup of IP set reading functions.
fasaxc
force-pushed
the
fix-ipset-filter
branch
from
7c977ea
to
04c3b86
Compare
|
/merge-when-ready |
tomastigera
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In BPF mode, we don't want to program linux IP sets unless we're using "untracked" policy, which is partially implemented in iptables. The filter to prevent IP set programming was only set after a policy churn.
Related issues/PRs
CORE-9898
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.