fix host to self without ctlb #8189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
tomastigera
added
docs-completed
lo program is meant for intercept services if there is no CTLB, but n this case, there is CTLB for TCP enabled. So sort-circuite that and allow.
We policy in other places and we would hit an invalid state if we did it here.
It makes no sense to enable ctlb and also host nat. It may make no sense to disable both, but that would conform with the original behaviour of BPFConnectTimeLoadBalancingEnabled=true/false. So we just emit a warning as this may be used as a big red button.
do not override FELIX_BPFHostNetworkedNATWithoutCTLB if set explicitly.
tomastigera
force-pushed
the
tomas-bpf-fix-host-nat
branch
from
2a51f43
to
4c5912b
Compare
3 tasks
| @@ -718,8 +718,8 @@ func NewIntDataplaneDriver(config Config) *InternalDataplane { | |||
|
|
|||
| if config.BPFConnTimeLB == string(apiv3.BPFConnectTimeLBDisabled) && | |||
| config.BPFHostNetworkedNAT == string(apiv3.BPFHostNetworkedNATDisabled) { | |||
| log.Warn("Access to services from host networked process wont work, forcing hostnetworked NAT to Enabled") | |||
| config.BPFHostNetworkedNAT = string(apiv3.BPFHostNetworkedNATEnabled) | |||
| log.Warn("Host-networked access to services from host networked process won't properly " + | |||
There was a problem hiding this comment.
won't work properly? If both are disabled, we are going to warn and leave it as it is?
There was a problem hiding this comment.
yes, this is a full rollback to the original behaviour and might be desired by the user if things regress
sridhartigera
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refs #4509
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.