Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.27] Fix incorrect cleanup of policy maps. #8231

Merged
merged 1 commit into from Nov 17, 2023

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Nov 16, 2023

Description

We would always clean up entries in the XDP map,
not the TC map when a device was removed.

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

ebpf: fixed policy cleanup after felix restart if a device is not present anymore

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

We would always clean up entries in the XDP map,
not the TC map when a device was removed.
@fasaxc fasaxc requested a review from a team as a code owner November 16, 2023 17:05
@marvin-tigera marvin-tigera added this to the Calico v3.27.0 milestone Nov 16, 2023
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Nov 16, 2023
Copy link
Contributor

@tomastigera tomastigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tomastigera tomastigera added docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented labels Nov 16, 2023
@fasaxc fasaxc merged commit 2e5ac6b into projectcalico:release-v3.27 Nov 17, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants