Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calico postrelease tests [master] #8552

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

danudey
Copy link
Contributor

@danudey danudey commented Feb 22, 2024

Add some fixes to the postrelease tests and bring them forward to the master branch

@danudey danudey requested a review from a team as a code owner February 22, 2024 22:50
@danudey danudey added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Feb 22, 2024
@danudey danudey self-assigned this Feb 22, 2024
@marvin-tigera marvin-tigera added this to the Calico v3.28.0 milestone Feb 22, 2024
@danudey danudey changed the title Port calico postrelease tests to master Update calico postrelease tests [master] Feb 22, 2024
Copy link
Member

@lwr20 lwr20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, a couple of questions for other folks.

hack/postrelease/Dockerfile Show resolved Hide resolved
"calico/cni",
"calico/kube-controllers",
"calico/upgrade",
"calico/windows",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list appears to be missing the node-windows and cni-windows images.

Suggested change
"calico/windows",
"calico/windows",
"calico/windows-upgrade",
"calico/node-windows",
"calico/cni-windows",

windows-upgrade and windows images might be obsolete now that we use host-process-container install. @coutinhop would know for sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right @lwr20, windows and windows-upgrade should be removed starting v3.27.0, and also node-windows and cni-windows should be added

hack/postrelease/tests/test_images.py Show resolved Hide resolved
hack/postrelease/Makefile Outdated Show resolved Hide resolved
@danudey danudey force-pushed the refactor_postrelease_tests_master branch from d52ead1 to a8929f9 Compare March 27, 2024 17:45
@radTuti radTuti modified the milestones: Calico v3.28.0, Calico v3.28.1 May 3, 2024
@caseydavenport
Copy link
Member

@danudey is this PR still in progress or should it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants