-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calico postrelease tests [master] #8552
base: master
Are you sure you want to change the base?
Update calico postrelease tests [master] #8552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, a couple of questions for other folks.
"calico/cni", | ||
"calico/kube-controllers", | ||
"calico/upgrade", | ||
"calico/windows", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list appears to be missing the node-windows
and cni-windows
images.
"calico/windows", | |
"calico/windows", | |
"calico/windows-upgrade", | |
"calico/node-windows", | |
"calico/cni-windows", |
windows-upgrade
and windows
images might be obsolete now that we use host-process-container install. @coutinhop would know for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right @lwr20, windows
and windows-upgrade
should be removed starting v3.27.0, and also node-windows
and cni-windows
should be added
d52ead1
to
a8929f9
Compare
@danudey is this PR still in progress or should it be closed? |
Add some fixes to the postrelease tests and bring them forward to the master branch