Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'release notes exist' validation to release process #8786

Conversation

danudey
Copy link
Contributor

@danudey danudey commented May 6, 2024

Performs some validations on the release notes file before starting a release:

Release notes file does not exist:

❯ hack/release/release -create
time="2024-05-06T11:42:15-07:00" level=info msg="Running git command" cmd="/usr/bin/git describe --exact-match --tags HEAD"
fatal: no tag exactly matches 'e603ce9fe8158f05268f718fb2a45976b9e3478f'
time="2024-05-06T11:42:15-07:00" level=info msg="Running git command" cmd="/usr/bin/git rev-parse --is-shallow-repository"
false
time="2024-05-06T11:42:15-07:00" level=info msg="Running git command" cmd="/usr/bin/git rev-parse --abbrev-ref HEAD"
dfox_validate_release_notes_v3.28
time="2024-05-06T11:42:15-07:00" level=info msg="Running git command" cmd="/usr/bin/git describe --tags --dirty --always --abbrev=12"
v3.28.0-0.dev-567-ge603ce9fe815
time="2024-05-06T11:42:15-07:00" level=info msg="Current git describe" out=v3.28.0-0.dev-567-ge603ce9fe815
time="2024-05-06T11:42:15-07:00" level=error msg="Failed to create Calico release" error="release notes file is invalid: stat release-notes/v3.28.0-release-notes.md: no such file or directory"

Release notes file is empty (0 bytes):

❯ hack/release/release -create
time="2024-05-06T11:46:43-07:00" level=info msg="Running git command" cmd="/usr/bin/git describe --exact-match --tags HEAD"
fatal: no tag exactly matches 'e603ce9fe8158f05268f718fb2a45976b9e3478f'
time="2024-05-06T11:46:43-07:00" level=info msg="Running git command" cmd="/usr/bin/git rev-parse --is-shallow-repository"
false
time="2024-05-06T11:46:43-07:00" level=info msg="Running git command" cmd="/usr/bin/git rev-parse --abbrev-ref HEAD"
dfox_validate_release_notes_v3.28
time="2024-05-06T11:46:43-07:00" level=info msg="Running git command" cmd="/usr/bin/git describe --tags --dirty --always --abbrev=12"
v3.28.0-0.dev-567-ge603ce9fe815
time="2024-05-06T11:46:43-07:00" level=info msg="Current git describe" out=v3.28.0-0.dev-567-ge603ce9fe815
time="2024-05-06T11:46:43-07:00" level=error msg="Failed to create Calico release" error="release notes file is invalid: file is 0 bytes"

@danudey danudey requested a review from a team as a code owner May 6, 2024 18:42
@danudey danudey added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels May 6, 2024
@danudey danudey self-assigned this May 6, 2024
@marvin-tigera marvin-tigera added this to the Calico v3.28.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants