add new interface option for skipping interfaces and expand interface option to take multiple regexes #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Should be good to go as soon as the calicoctl change has been merged. Also, will need to be rebased off the latest master before we merge. |
|
Tests require #904 in order to pass |
option to take multiple regexes
robbrockbank
approved these changes
Jul 11, 2017
caseydavenport
added
the
release-note-required
caseydavenport
pushed a commit
that referenced
this pull request
Dec 14, 2021
…-master [master] Semaphore Auto Pin Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an option to skip network interfaces specified by regexes so that users can have first-found logic without having to manually specify system/setup specific interfaces to skip by changing the code.
Requires/is required by projectcalico/calicoctl#1675
Addresses projectcalico/calicoctl#1555
Builds off of #878
Testing
Release Notes